TransferList.Toolbar implements toolbar pattern
#2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
reviewed
Oct 2, 2024
mayank99
approved these changes
Oct 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After #2263, tooltips now have a default delay. This, in addition to the vertical placement of the tooltips in
TransferList.Toolbarmake it difficult to go from one button to another.This PR fixes this by using a
<ButtonGroup orientation="vertical" />forTransferList.Toolbarunder the hood. The tooltips now show to the right (#1709) and with no delay when going from one button to the adjacent one (#1524).Additionally, this also improves accessibility since
<ButtonGroup role="toolbar">implements the toolbar pattern with arrow-key navigation functionality.Testing
Enregistrement.de.l.ecran.2024-09-27.a.10.33.12.mov
Enregistrement.de.l.ecran.2024-09-27.a.10.32.07.mov
Enregistrement.de.l.ecran.2024-10-01.a.17.50.56.mov
Enregistrement.de.l.ecran.2024-10-01.a.17.48.45.mov
Docs
Added minor changesets.